Jenkins job DLDG/gitlab-builds #203 succeeded in 1 min 49 sec.See Console Output, Blue Ocean and Coverage Report for more details.

So I opened !191 instead that simplifies the from_disk module implementation and remove the deprecation notice.

mr [1] which deprecated it....

If it is still used, better removing the deprecated flag. We can also re-implement GitLoaderFromDisk in a similar way as done in swh-web by inherit...

I don't know, I didn't issue the deprecation. Cc. @vlorentz and @ardumont who did.

Why is it deprecated then ?

Isn't this code that we'd still use if we were given a set of zip files for a bunch of repositories? Or if we were given a set of repositories arch...

Jenkins job DLDG/gitlab-builds #202 succeeded in 1 min 47 sec.See Console Output, Blue Ocean and Coverage Report for more details.

Jenkins job DLDG/gitlab-builds #200 succeeded in 1 min 50 sec.See Console Output, Blue Ocean and Coverage Report for more details.

You're right, I have added a bit of context for this change in the mr description.

Seems fine to me, after checking the code extra really is an alias for _extra (I was concerned that it might give access to all headers instead of ...

Jenkins job DLDG/gitlab-builds #198 succeeded .See Console Output, Blue Ocean and Coverage Report for more details.