Staging instance, all changes can be removed at any time

Skip to content
Snippets Groups Projects
Jenkins Bot's avatar
commented on merge request !191 "from_disk: Update loader classes implementation" at Platform / Development / swh-loader-git

Jenkins job DLDG/gitlab-builds #203 succeeded in 1 min 49 sec.See Console Output, Blue Ocean and Coverage Report for more details.

Antoine Lambert's avatar
commented on merge request !190 "Remove deprecated and no longer used from_disk module" at Platform / Development / swh-loader-git

So I opened !191 instead that simplifies the from_disk module implementation and remove the deprecation notice.

Antoine Lambert's avatar
opened merge request !191 "from_disk: Update loader classes implementation" at Platform / Development / swh-loader-git
Antoine R. Dumont's avatar
commented on merge request !190 "Remove deprecated and no longer used from_disk module" at Platform / Development / swh-loader-git

mr [1] which deprecated it....

Antoine Lambert's avatar
commented on merge request !190 "Remove deprecated and no longer used from_disk module" at Platform / Development / swh-loader-git

If it is still used, better removing the deprecated flag. We can also re-implement GitLoaderFromDisk in a similar way as done in swh-web by inherit...

Nicolas Dandrimont's avatar
commented on merge request !190 "Remove deprecated and no longer used from_disk module" at Platform / Development / swh-loader-git

I don't know, I didn't issue the deprecation. Cc. @vlorentz and @ardumont who did.

Antoine Lambert's avatar
commented on merge request !190 "Remove deprecated and no longer used from_disk module" at Platform / Development / swh-loader-git

Why is it deprecated then ?

Nicolas Dandrimont's avatar
commented on merge request !190 "Remove deprecated and no longer used from_disk module" at Platform / Development / swh-loader-git

Isn't this code that we'd still use if we were given a set of zip files for a bunch of repositories? Or if we were given a set of repositories arch...

Jenkins Bot's avatar
commented on merge request !190 "Remove deprecated and no longer used from_disk module" at Platform / Development / swh-loader-git

Jenkins job DLDG/gitlab-builds #202 succeeded in 1 min 47 sec.See Console Output, Blue Ocean and Coverage Report for more details.

Antoine Lambert's avatar
opened merge request !190 "Remove deprecated and no longer used from_disk module" at Platform / Development / swh-loader-git
Antoine Lambert's avatar
pushed to branch master at Platform / Development / swh-loader-git
  • 0dd744df · tests: Fix numerous tests after recent changes in loader-core
Antoine Lambert's avatar
accepted merge request !188 "tests: Fix numerous tests after recent changes in loader-core" at Platform / Development / swh-loader-git
Jenkins Bot's avatar
commented on merge request !188 "tests: Fix numerous tests after recent changes in loader-core" at Platform / Development / swh-loader-git

Jenkins job DLDG/gitlab-builds #200 succeeded in 1 min 50 sec.See Console Output, Blue Ocean and Coverage Report for more details.

Renaud Boyer's avatar
pushed to branch master at Platform / Development / swh-loader-git
  • 48d0acfa · Fix Commit.extra is deprecated
Renaud Boyer's avatar
accepted merge request !189 "Fix Commit.extra is deprecated" at Platform / Development / swh-loader-git
Renaud Boyer's avatar
commented on merge request !189 "Fix Commit.extra is deprecated" at Platform / Development / swh-loader-git

You're right, I have added a bit of context for this change in the mr description.

Nicolas Dandrimont's avatar
approved merge request !188 "tests: Fix numerous tests after recent changes in loader-core" at Platform / Development / swh-loader-git
Nicolas Dandrimont's avatar
commented on merge request !189 "Fix Commit.extra is deprecated" at Platform / Development / swh-loader-git

Seems fine to me, after checking the code extra really is an alias for _extra (I was concerned that it might give access to all headers instead of ...

Nicolas Dandrimont's avatar
approved merge request !189 "Fix Commit.extra is deprecated" at Platform / Development / swh-loader-git
Jenkins Bot's avatar
commented on merge request !189 "Fix Commit.extra is deprecated" at Platform / Development / swh-loader-git

Jenkins job DLDG/gitlab-builds #198 succeeded .See Console Output, Blue Ocean and Coverage Report for more details.