Staging instance, all changes can be removed at any time

Skip to content

Rename JournalClient.max_messages to JournalClient.stop_after_objects

Nicolas Dandrimont requested to merge generated-differential-D2798-source into generated-differential-D2798-target

After various refactorings, the meaning of max_messages got muddled and we're at a point where it doesn't mean anything anymore. stop_after_objects is clearer as to what behavior the parameter is actually trying to achieve. We also rename the replay command-line argument to the same name.

These refactorings also had us end up with a loop inside JournalClient.process, while some callers still had a loop around it which ever got called once (or 0 times when the surrounding code was buggy). This commit removes all these outer loops as well, keeping only the JournalClient.process inner loop.

While we're here, we use the opportunity to clarify and expand the documentation of the JournalClient.

Depends on !122 (closed).

Test Plan

all relevant tox tests updated

Migrated from D2798 (view on Phabricator)

Merge request reports