Refactor revision_get storage API to return Revision objects (!986) · Merge requests · Platform / Development / swh-storage

Antoine R. Dumont requested to merge generated-differential-D3863-source into generated-differential-D3863-target Sep 02, 2020
The signature becomes revision_get(...) -> List[Optional[Revision]]
Impacts:
swh-deposit!375 (closed): swh-deposit
swh-indexer!453 (closed): swh-indexer
swh-loader-core!400 (closed): swh-loader-core
swh-loader-mercurial!121 (closed): swh-loader-mercurial
swh-loader-svn!199 (closed): swh-loader-svn
swh-web!1016 (closed): swh-web
$ grep -r "revision_get" $SWH_ENVIRONMENT_HOME/*/swh/** | grep -v swh/storage | grep revision_get
$SWH_ENVIRONMENT_HOME/swh-deposit/swh/deposit/migrations/0018_migrate_swhids.py:        revisions = list(storage.revision_get([rev_id_bytes]))
$SWH_ENVIRONMENT_HOME/swh-indexer/swh/indexer/indexer.py:        for rev in self.storage.revision_get(revision_ids):
$SWH_ENVIRONMENT_HOME/swh-indexer/swh/indexer/metadata.py:                self.storage.revision_get, head_rev_ids, REVISION_GET_BATCH_SIZE
$SWH_ENVIRONMENT_HOME/swh-loader-core/swh/loader/tests/__init__.py:        revisions = list(storage.revision_get(revs))
$SWH_ENVIRONMENT_HOME/swh-loader-core/swh/loader/package/pypi/tests/test_pypi.py:    revision = list(loader.storage.revision_get([expected_revision_id]))[0]
$SWH_ENVIRONMENT_HOME/swh-loader-core/swh/loader/package/nixguix/loader.py:        known_revisions = self.storage.revision_get(revs)
$SWH_ENVIRONMENT_HOME/swh-loader-core/swh/loader/package/nixguix/loader.py:            if not revision:  # revision_get can return None
$SWH_ENVIRONMENT_HOME/swh-loader-core/swh/loader/package/nixguix/tests/test_nixguix.py:    revisions = storage.revision_get(revision_ids)
$SWH_ENVIRONMENT_HOME/swh-loader-core/swh/loader/package/nixguix/tests/test_nixguix.py:        old_revision = next(loader.storage.revision_get([first_revision.target]))
$SWH_ENVIRONMENT_HOME/swh-loader-core/swh/loader/package/nixguix/tests/test_nixguix.py:        new_revision = next(loader.storage.revision_get([new_revision_branch.target]))
$SWH_ENVIRONMENT_HOME/swh-loader-core/swh/loader/package/archive/tests/test_archive.py:    revision = list(loader.storage.revision_get([expected_revision_id]))[0]
$SWH_ENVIRONMENT_HOME/swh-loader-core/swh/loader/package/loader.py:        known_revisions = self.storage.revision_get(revs)
$SWH_ENVIRONMENT_HOME/swh-loader-core/swh/loader/package/deposit/loader.py:            revisions = list(self.storage.revision_get([rev_id]))
$SWH_ENVIRONMENT_HOME/swh-loader-core/swh/loader/package/deposit/tests/test_deposit.py:    revision = list(loader.storage.revision_get([expected_revision_id]))[0]
$SWH_ENVIRONMENT_HOME/swh-loader-core/swh/loader/package/deposit/tests/test_deposit.py:    revision = next(loader.storage.revision_get([revision_id]))
$SWH_ENVIRONMENT_HOME/swh-loader-core/swh/loader/package/deposit/tests/test_deposit.py:    revision = next(loader.storage.revision_get([hash_to_bytes(revision_id)]))
$SWH_ENVIRONMENT_HOME/swh-loader-core/swh/loader/package/npm/tests/test_npm.py:    revision = list(loader.storage.revision_get([expected_revision_id]))[0]
$SWH_ENVIRONMENT_HOME/swh-loader-mercurial/swh/loader/mercurial/tests/test_loader.py:    revision = loader.storage.revision_get([tip_revision_default])
$SWH_ENVIRONMENT_HOME/swh-loader-svn/swh/loader/svn/loader.py:        revs = list(storage.revision_get([swh_id]))
$SWH_ENVIRONMENT_HOME/swh-loader-svn/swh/loader/svn/tests/test_loader.py:        loader.storage.revision_get(
$SWH_ENVIRONMENT_HOME/swh-loader-svn/swh/loader/svn/tests/test_loader.py:        loader.storage.revision_get(
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/common/service.py:    revision = _first_element(storage.revision_get([sha1_git_bin]))
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/common/service.py:    revisions = storage.revision_get(sha1_bin_list) or []
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/common/service.py:    revision = _first_element(storage.revision_get([sha1_git_bin]))
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/common/service.py:    rev_root = _first_element(storage.revision_get([rev_root_id_bin]))
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/common/service.py:    revision = _first_element(storage.revision_get([sha1_git_bin]))
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/common/service.py:        revision_root = _first_element(storage.revision_get([sha1_git_root_bin]))
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/common/service.py:    revision = _first_element(storage.revision_get([sha1_git_bin]))
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/common/service.py:        revision = next(storage.revision_get([entity["target"]]))
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/browse/views/test_origin.py:        head_rev = archive_data.revision_get(head_rev_id)
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/browse/views/test_origin.py:    head_rev = archive_data.revision_get(head_rev_id)
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/browse/views/test_origin.py:    head_rev = archive_data.revision_get(head_rev_id)
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/browse/views/test_origin.py:    revision_data = archive_data.revision_get(release_data["target"])
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/browse/views/test_revision.py:    revision_data = archive_data.revision_get(revision)
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/browse/views/test_content.py:    directory = archive_data.revision_get(branch_info["revision"])["directory"]
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/browse/views/test_release.py:            rev = archive_data.revision_get(release_data["target"])
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/browse/views/test_identifiers.py:    directory = archive_data.revision_get(revision)["directory"]
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/browse/views/test_directory.py:    directory = archive_data.revision_get(branch_info["revision"])["directory"]
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/browse/test_snapshot_context.py:                rev_data = archive_data.revision_get(branch_data["target"])
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/browse/test_snapshot_context.py:                rev_data = archive_data.revision_get(rel_data["target"])
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/browse/test_snapshot_context.py:        revision_info = archive_data.revision_get(revision_id)
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/api/views/test_revision.py:    expected_revision = archive_data.revision_get(revision)
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/api/views/test_revision.py:    expected_message = archive_data.revision_get(revision)["message"]
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/api/test_utils.py:    revision_data = archive_data.revision_get(revision)
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/api/test_utils.py:    revision_data = archive_data.revision_get(revision)
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/api/test_utils.py:    revision_data = archive_data.revision_get(revision)
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/api/test_utils.py:    revision_data = archive_data.revision_get(revision)
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/data.py:        for rev in storage.revision_get(revisions):
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/common/test_identifiers.py:    revision_data = archive_data.revision_get(revision)
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/common/test_identifiers.py:        head_rev = archive_data.revision_get(head_rev_id)
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/common/test_identifiers.py:    directory = archive_data.revision_get(branch_info["revision"])["directory"]
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/common/test_service.py:        expected_revision = archive_data.revision_get(sha1_git)
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/common/test_service.py:    revision = archive_data.revision_get(revision_with_submodules["rev_sha1_git"])
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/common/test_service.py:        "content": archive_data.revision_get(rev_entry["target"]),
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/common/test_service.py:    revision_data = archive_data.revision_get(revision)
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/common/test_service.py:    rev_data = archive_data.revision_get(revision)
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/common/test_service.py:    rev_data = archive_data.revision_get(revision)
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/common/test_service.py:    assert actual_revision == archive_data.revision_get(revision)
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/common/test_service.py:        expected_revisions.append(archive_data.revision_get(rev))
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/common/test_service.py:    expected_revision = archive_data.revision_get(branches[branch_name]["target"])
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/common/test_service.py:    expected_root_rev = archive_data.revision_get(root_rev)
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/common/test_service.py:    expected_rev = archive_data.revision_get(rev)
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/common/test_service.py:    rev_data = archive_data.revision_get(revision)
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/common/test_service.py:    rev_data = archive_data.revision_get(revision)
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/common/test_service.py:    expected = archive_data.revision_get(revision)
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/conftest.py:    def revision_get(self, rev_id):
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/conftest.py:        rev_data = next(self.storage.revision_get([rev_id_bytes]))
$SWH_ENVIRONMENT_HOME/swh-web/swh/web/tests/strategies.py:        lambda s: next(get_tests_data()["storage"].revision_get([hash_to_bytes(s)]))
Related to T645
Test Plan

tox
Migrated from D3863 (view on Phabricator)
Silent mode is enabled

Refactor revision_get storage API to return Revision objects

Test Plan

Merge request reports
